MSC2454: Support UI auth for SSO

[clokep]

Rendered

Based on @richvdh's write up: https://docs.google.com/document/d/1sA9cTKRE93TczvxuHgZ6q1A54xYtDVjmwsRu_K7vbvM

[ara4n]

This looks cool and very comprehensive, but i’m a bit confused on what bits are actually proposed changes to the spec rather than implementation notes?

I think the bit which is confusing me is:

In theory, any clients that already implement the fallback process for unknown authentication types will work fine without modification.

If clients don’t need changes, why is a spec change needed?

[clokep]

I'll work to clarify the proposal section of this, but the short version is to add an m.login.sso type to the list of possible ui-auth types: https://matrix.org/docs/spec/client_server/r0.6.0#authentication-types.

The quoted sentence is meant to mean "if the client implements the fallback process already for other workflows it will probably work fine here too". I moved that around from Rich's original proposal and likely made it more confusing, sorry about that!

[clokep]

I removed a couple pieces and tried to clarify the value and changes that this is proposing.

[richvdh]

I think I wrote most of this, so obviously it lgtm :).

I'd echo @turt2live's comments that we should emphasise that the only new thing here is the first paragraph of the proposal (a new authentication type). The rest is just a demonstration of how it works.

[anoadragon453]

@mscbot fcp merge

[mscbot]

Team member @anoadragon453 has proposed to merge this. The next step is review by the rest of the tagged people:

• @dbkr
• @uhoreg
• @turt2live
• @ara4n
• @anoadragon453
• @richvdh
• @erikjohnston
• @KitsuneRal

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

[uhoreg]

A few grammar nits/suggestions. I'm not an expert on UIAuth or SSO, but this seems largely sane.

[mscbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[mscbot]

The final comment period, with a disposition to merge, as per the review above, is now complete.

[turt2live]

Spec PR was #2532

[turt2live]

Merged 🎉