Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove required 'fieldname' in Protocol definition #1646

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Sep 26, 2023

This field does not exist and makes example validation fail. It does not change anything in the rendered spec.

My guess is that it was trying to mean that for every field in user_fields and location_fields, there should be an entry in field_types. It might be interesting to see if it is possible to define that using JSON schema.

Preview: https://pr1646--matrix-spec-previews.netlify.app

This field does not exist and makes example validation fail

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner September 26, 2023 11:15
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@richvdh richvdh merged commit c3098cc into matrix-org:main Oct 3, 2023
10 checks passed
@zecakeh zecakeh deleted the fix-protocol branch October 4, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants