Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that the User identifier object in POST /_matrix/client/v3/login contains additional properties that depend on the identification type #1909

Merged
merged 10 commits into from
Jul 30, 2024
Merged

Clarify that the User identifier object in POST /_matrix/client/v3/login contains additional properties that depend on the identification type #1909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
399e860
Handle additionalProperties: true like additionalProperties: {}
Johennes Jul 18, 2024
63af782
Add changelog
Johennes Jul 18, 2024
c0e5699
Add changelog
Johennes Jul 18, 2024
493058a
Enforce `additionalProperties: {}` instead of the equivalent `additio…
Johennes Jul 23, 2024
6849bfd
Relocate the assertion
Johennes Jul 23, 2024
20c109c
Restore blank line
Johennes Jul 23, 2024
de615f5
Switch from additionalProperties: {} to using a description
Johennes Jul 24, 2024
9699bba
Fix spelling of 'User identifier'
Johennes Jul 24, 2024
2ac8c42
Remove error on `additionalProperties: true`
Johennes Jul 25, 2024
726c646
Update data/api/client-server/definitions/user_identifier.yaml
richvdh Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/client_server/newsfragments/1909.clarification
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The `User identifier` object in `POST /_matrix/client/v3/login` contains additional properties that depend on the identification type.
7 changes: 5 additions & 2 deletions data/api/client-server/definitions/user_identifier.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ type: object
properties:
type:
type: string
description: The type of identification. See [Identifier types](/client-server-api/#identifier-types) for supported values and additional property descriptions.
description: |-
The type of identification. See [Identifier types](/client-server-api/#identifier-types)
for supported values and additional property descriptions.
required:
- type
additionalProperties: true
additionalProperties:
description: Keys dependent on the identification type.