-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 403 error response to federation/v1/state_ids #1926
base: main
Are you sure you want to change the base?
Add 403 error response to federation/v1/state_ids #1926
Conversation
fixes matrix-org#1912 by adding a 403 error response to /_matrix/federation/v1/state_ids/{roomId}
…ver/newsfragments/1926.feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also sign off your changes.
RESPONSE/server-server/edu.yaml | ||
|
||
Fixes issue #1912 by adding error response to /_matrix/federation/v1/state_ids/{roomId} | ||
|
||
CONTENT : | ||
"403": | ||
description: |- | ||
The host is not in the room or the host is banned from the room via its ACL. | ||
content: | ||
application/json: | ||
schema: | ||
$ref: ../client-server/definitions/errors/error.yaml | ||
examples: | ||
response: | ||
value: { | ||
"errcode": "M_FORBIDDEN", | ||
"error": "You do not have permission to access the state at the requested event." | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the rendered output of this PR:
This is not a useful changelog entry.
Please have a look at other changelog fragments, as well as the existing changelog, for examples of what might be appropriate here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes give me a bit of time I will definitely complete it . Can you also please give me a heads up about why the output is like this and a little bit information about changelog fragments ? Appreciate your help sir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you looked at other examples? Start there. If you still have questions, come back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay thank you sir
fixes #1912 by adding a 403 error response to /_matrix/federation/v1/state_ids/{roomId}
Pull Request Checklist
Fixes issue #1912 by adding error response to /_matrix/federation/v1/state_ids/{roomId}
Signed-off-by:
Srinjoy Sen Chowdhury srinjoysen123@gmail.com
Preview: https://pr1926--matrix-spec-previews.netlify.app