Sort VoIP events semantically #1967
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: matrix-org#937 Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Johennes
commented
Oct 10, 2024
zecakeh
reviewed
Oct 12, 2024
| {{ $event_data = partial "json-schema/resolve-refs" (dict "schema" $event_data "path" $path) }} | ||
| {{ $event_data := partial "json-schema/resolve-allof" $event_data }} | ||
| {{/* Render the events sorted by x-weight or otherwise their event name */}} | ||
| {{ range sort $events "event_data.x-weight" "event_name" }} |
There was a problem hiding this comment.
Does this work? It looks like the only thing you can put as the third argument to sort is "asc" or "desc": https://gohugo.io/functions/collections/sort/
| @@ -41,3 +41,8 @@ same use as `format`, but that applies to the pattern of the property. We also | |||
| define custom values for formats with the `mx-` prefix in | |||
| `data/custom-formats.yaml`. Those values are recognized in the rendered | |||
| specification and link to the definition of the format. | |||
|
|
|||
| ## Custom `x-weight` key | |||
There was a problem hiding this comment.
Unless x-weight is a colloquial identifier, x-sort-weight may be slightly more self-descriptive?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an
x-weightproperty that can be used to influence the order of events rendered with theevent-groupshortcode and uses it to put the VoIP events into semantic order.Fixes: #937
Pull Request Checklist
Preview: https://pr1967--matrix-spec-previews.netlify.app