Clarify that pusher URLs have a fixed path #1974
Open
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: matrix-org#809 Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Comment on lines
+38
to
+40
| Clients interested in receiving notifications via this endpoint MUST | ||
| configure its concrete URL when creating the associated pusher via | ||
| [`/_matrix/client/v3/pushers/set`](/client-server-api/#post_matrixclientv3pushersset). |
There was a problem hiding this comment.
I'm not sure if this really tells me "the path must be /_matrix/push/v1/notify".
What do you mean by "concrete URL"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #809
Pull Request Checklist
Preview: https://pr1974--matrix-spec-previews.netlify.app