Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reason why the archive bot is joining the room #262

Merged
merged 9 commits into from
Jun 9, 2023

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Jun 6, 2023

Add reason why the archive bot is joining the room

Using the join reason added in MSC2367. Unfortunately, this PR doesn't have much effect because it doesn't look like many clients support it yet (Element doesn't support it for example).

Part of #257

Using the join `reason` added in MSC2367

Related to adding some better profile information, #257 (comment)
@MadLittleMods MadLittleMods added documentation Improvements or additions to documentation T-Enhancement New feature or request labels Jun 6, 2023
docs/faq.md Outdated Show resolved Hide resolved
body: {
reason:
`Joining room to check history visibility. ` +
`If your room is public with shared or world readable history visibility, ` +
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is hostile wording towards the users as the term shared doesn't appear outside of the spec. Please consider using client terminology such as Element Web members-only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the FAQ with the equivalents you might see in the UI but it's not possible to be exhaustive for how every client might expose these options. We're also trying to be brief and to the point with this join reason so I'm going to just let the pointer to the FAQ take the lead for people trying to understand more.

docs/faq.md Show resolved Hide resolved
@MTRNord
Copy link

MTRNord commented Jun 6, 2023

(Element doesn't support it for example).

I believe element android shows them. Not sure if its on join though.
Web for sure doesn't :/

docs/faq.md Outdated Show resolved Hide resolved
@MadLittleMods MadLittleMods marked this pull request as ready for review June 7, 2023 19:11
@MadLittleMods MadLittleMods merged commit 1dd6321 into main Jun 9, 2023
@MadLittleMods
Copy link
Contributor Author

Thanks for the review @Mikaela and @MTRNord 🦘

MadLittleMods added a commit that referenced this pull request Jun 9, 2023
MadLittleMods added a commit that referenced this pull request Jun 22, 2023
Fix #267

In the case of someone visiting a room via an alias, we can't get access to the `room_id` before we join the room. I've opted to just point to the Matrix Public Archive instance in general. This way the `join` reason is always stable regardless how someone is visiting the room.

Join `reason` was originally added in #262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation T-Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants