Allow room_alias_name parameter to be handled by /createRoom calls …

…on workers (#10757)
matrix-org · Sep 6, 2021 · 40a1fdd · 40a1fdd
1 parent 7bb3673
commit 40a1fdd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/changelog.d/10757.bugfix b/changelog.d/10757.bugfix
@@ -0,0 +1 @@
+Fix a bug which prevented calls to `/createRoom` that included the `room_alias_name` parameter from being handled by worker processes.
diff --git a/synapse/storage/databases/main/directory.py b/synapse/storage/databases/main/directory.py
@@ -75,8 +75,6 @@ async def get_aliases_for_room(self, room_id: str) -> List[str]:
             desc="get_aliases_for_room",
         )
 
-
-class DirectoryStore(DirectoryWorkerStore):
     async def create_room_alias_association(
         self,
         room_alias: RoomAlias,
@@ -126,6 +124,8 @@ def alias_txn(txn):
                 409, "Room alias %s already exists" % room_alias.to_string()
             )
 
+
+class DirectoryStore(DirectoryWorkerStore):
     async def delete_room_alias(self, room_alias: RoomAlias) -> str:
         room_id = await self.db_pool.runInteraction(
             "delete_room_alias", self._delete_room_alias_txn, room_alias