Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Remove remaining is_guest argument uses from get_room_data calls (#8181)
Browse files Browse the repository at this point in the history
#8174 removed the `is_guest` parameter from `get_room_data`, at the same time that #8157 was merged using it, colliding together to break unit tests on develop.

This PR removes the `is_guest` parameter from the call in the broken test.

Uses the same changelog as #8174.
  • Loading branch information
anoadragon453 authored Aug 26, 2020
1 parent 6fe12c9 commit b8f20e4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 10 deletions.
1 change: 1 addition & 0 deletions changelog.d/8181.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove unused `is_guest` parameter from, and add safeguard to, `MessageHandler.get_room_data`.
12 changes: 2 additions & 10 deletions tests/rest/client/test_shadow_banned.py
Original file line number Diff line number Diff line change
Expand Up @@ -271,11 +271,7 @@ def test_displayname(self):
message_handler = self.hs.get_message_handler()
event = self.get_success(
message_handler.get_room_data(
self.banned_user_id,
room_id,
"m.room.member",
self.banned_user_id,
False,
self.banned_user_id, room_id, "m.room.member", self.banned_user_id,
)
)
self.assertEqual(
Expand Down Expand Up @@ -308,11 +304,7 @@ def test_room_displayname(self):
message_handler = self.hs.get_message_handler()
event = self.get_success(
message_handler.get_room_data(
self.banned_user_id,
room_id,
"m.room.member",
self.banned_user_id,
False,
self.banned_user_id, room_id, "m.room.member", self.banned_user_id,
)
)
self.assertEqual(
Expand Down

0 comments on commit b8f20e4

Please sign in to comment.