Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Receipts worker needs to be sharded #16417

Closed
erikjohnston opened this issue Oct 2, 2023 · 1 comment · Fixed by #16432
Closed

Receipts worker needs to be sharded #16417

erikjohnston opened this issue Oct 2, 2023 · 1 comment · Fixed by #16432
Labels
A-Workers Problems related to running Synapse in Worker Mode (or replication) O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@erikjohnston
Copy link
Member

Currently we can only run one receipts worker, we should be able to shard this.

Annoyingly, it looks like most of the CPU cost for receipts is just "overhead", i.e. receiving HTTP requests, DB pool, and replication overhead.

A representative flame.svg:

flame
@clokep
Copy link
Member

clokep commented Oct 2, 2023

replication overhead

#12461 maybe?

@clokep clokep added A-Workers Problems related to running Synapse in Worker Mode (or replication) S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Oct 2, 2023
@erikjohnston erikjohnston mentioned this issue Oct 5, 2023
Merged
erikjohnston added a commit that referenced this issue Oct 25, 2023
@erikjohnston
Allow multiple workers to write to receipts stream. (#16432)
ba47fea 
Fixes #16417
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Workers Problems related to running Synapse in Worker Mode (or replication) O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow multiple workers to write to receipts stream. matrix-org/synapse
2 participants
@clokep @erikjohnston