This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
default in encryption_enabled_by_default_for_room_type is misleading #9794
Labels
good first issue
Good for newcomers
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Comments
|
Indeed, the description at least should be updated, if not the name as well. A similar conclusion was reached at the end of #9246, but nobody ended up creating an issue off the back of it. Thanks for doing so! |
anoadragon453
added
good first issue
|
Heads up that #9794 is an on-going, initial attempt at addressing this issue. |
|
itym #9983 |
Adnan-030
added a commit
to Adnan-030/synapse
that referenced
this issue
Jan 29, 2023
ADNAN -- ISSUE matrix-org#9794
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
The option
encryption_enabled_by_default_for_room_typeas introduced in #7639 is misleading.A default is something that has a value as long as it's not overwritten. In this case it would mean, that encryption is enabled for the specified room type as long as it is not disabled for a specific room/client/...
The current implementation prevents creation of unencrypted DMs/rooms. This is clearly not a default, but forced encryption.
Expected Naming
force_encryption_enabled_for_room_typeor similar.Version information
v1.31.0and currentdevelopbranch.The text was updated successfully, but these errors were encountered: