Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Type hints for the remaining two files in synapse.http. #11164

Merged
merged 9 commits into from
Oct 28, 2021
Merged

Type hints for the remaining two files in synapse.http. #11164

merged 9 commits into from
Oct 28, 2021

Commits on Oct 22, 2021

  1. Teach MyPy that the sentinel context is False 

    This means that if `ctx: LoggingContextOrSentinel`
then `bool(ctx)` narrows us to `ctx:LoggingContext`, which is a really
neat find!
    David Robertson committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    7f9fe6c View commit details
    Browse the repository at this point in the history

  2. Annotate RequestMetrics 

    - Raise errors for sentry if we use the sentinel context
- Ensure we don't raise an error and carry on, but not recording stats
- Include stack trace in the error case to lower Sean's blood pressure
    David Robertson committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    48cf46c View commit details
    Browse the repository at this point in the history

  3. Make mypy pass for synapse.http.request_metrics

    David Robertson committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    df7bdbc View commit details
    Browse the repository at this point in the history

  4. Make synapse.http.connectproxyclient pass mypy

    David Robertson committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    f5287d9 View commit details
    Browse the repository at this point in the history

  5. synapse.http now passes mypy

    David Robertson committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    2ae227e View commit details
    Browse the repository at this point in the history

  6. Changelog

    David Robertson committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    4634368 View commit details
    Browse the repository at this point in the history

  7. typo fix 

    Co-authored-by: reivilibre <oliverw@matrix.org>
    @reivilibre
    David Robertson and reivilibre authored Oct 22, 2021
    Configuration menu
    Copy the full SHA
    f362cd6 View commit details
    Browse the repository at this point in the history

  8. Try to express that counts are int, not float

    David Robertson committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    8ee9d35 View commit details
    Browse the repository at this point in the history

  9. Fix sytest. Not sure about this.

    David Robertson committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    af428f7 View commit details
    Browse the repository at this point in the history