Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Drop tables used for groups/communities. #12967

Merged
merged 2 commits into from
Jul 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/12967.removal
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Drop tables used for groups/communities.
16 changes: 0 additions & 16 deletions synapse/_scripts/synapse_port_db.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,22 +166,6 @@
"ui_auth_sessions",
"ui_auth_sessions_credentials",
"ui_auth_sessions_ips",
# Groups/communities is no longer supported.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is safe to remove since a user will have run the delta before running the port DB code?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we call build_db_store at the start of run on both stores, which in turns calls prepare_database and runs the delta.

"group_attestations_remote",
"group_attestations_renewals",
"group_invites",
"group_roles",
"group_room_categories",
"group_rooms",
"group_summary_roles",
"group_summary_room_categories",
"group_summary_rooms",
"group_summary_users",
"group_users",
"groups",
"local_group_membership",
"local_group_updates",
"remote_profile_cache",
}


Expand Down
7 changes: 4 additions & 3 deletions synapse/storage/schema/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,14 @@

Changes in SCHEMA_VERSION = 72:
- event_edges.(room_id, is_state) are no longer written to.
- Tables related to groups are dropped.
"""


SCHEMA_COMPAT_VERSION = (
# We no longer maintain `event_edges.room_id`, so synapses with SCHEMA_VERSION < 71
# will break.
71
# The groups tables are no longer accessible, so synapses with SCHEMA_VERSION < 72
# could break.
72
)
"""Limit on how far the synapse codebase can be rolled back without breaking db compat

Expand Down
31 changes: 31 additions & 0 deletions synapse/storage/schema/main/delta/72/03remove_groups.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
/* Copyright 2022 The Matrix.org Foundation C.I.C
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

-- Remove the tables which powered the unspecced groups/communities feature.
DROP TABLE IF EXISTS group_attestations_remote;
DROP TABLE IF EXISTS group_attestations_renewals;
DROP TABLE IF EXISTS group_invites;
DROP TABLE IF EXISTS group_roles;
DROP TABLE IF EXISTS group_room_categories;
DROP TABLE IF EXISTS group_rooms;
DROP TABLE IF EXISTS group_summary_roles;
DROP TABLE IF EXISTS group_summary_room_categories;
DROP TABLE IF EXISTS group_summary_rooms;
DROP TABLE IF EXISTS group_summary_users;
DROP TABLE IF EXISTS group_users;
DROP TABLE IF EXISTS groups;
DROP TABLE IF EXISTS local_group_membership;
DROP TABLE IF EXISTS local_group_updates;
DROP TABLE IF EXISTS remote_profile_cache;