Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove redundant room_version object from event auth functions #13017

Merged
merged 5 commits into from
Jun 13, 2022
Merged

Remove redundant room_version object from event auth functions #13017

merged 5 commits into from
Jun 13, 2022

Commits on Jun 12, 2022

  1. EventAuthTestCase: build events for the right room version 

    In practice, when we run the auth rules, all of the events have the right room
version. Let's stop building Room V1 events for these tests and use the right
version.
    @richvdh
    richvdh committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    2959184 View commit details
    Browse the repository at this point in the history

  2. Remove room_version param from validate_event_for_room_version 

    Instead, use the `room_version` property of the event we're validating.

The `room_version` was originally added as a parameter somewhere around #4482,
but really it's been redundant since #6875 added a `room_version` field to `EventBase`.
    @richvdh
    richvdh committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    68be42f View commit details
    Browse the repository at this point in the history

  3. Remove room_version param from check_auth_rules_for_event 

    Instead, use the `room_version` property of the event we're checking.

The `room_version` was originally added as a parameter somewhere around #4482,
but really it's been redundant since #6875 added a `room_version` field to `EventBase`.
    @richvdh
    richvdh committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    0d9d36b View commit details
    Browse the repository at this point in the history

  4. Remove redundant room_version param from `check_auth_rules_from_con… 

    …text`

It's now implied by the room_version property on the event.
    @richvdh
    richvdh committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    c1b28b8 View commit details
    Browse the repository at this point in the history

  5. changelog

    @richvdh
    richvdh committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    a6173a1 View commit details
    Browse the repository at this point in the history