Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Draft: Prevent Failed to fetch missing state events... warning being logged every time we tried to fetch state_ids for a missing prev_event (_get_state_ids_after_missing_prev_event(...)) #13249

Closed

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Jul 11, 2022

Prevent Failed to fetch missing state events... warning being logged every time we tried to fetch state_ids for a missing prev_event (_get_state_ids_after_missing_prev_event(...))

Discovered while working on #13205 (comment)

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

@MadLittleMods MadLittleMods added the T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. label Jul 11, 2022
@@ -939,20 +939,26 @@ async def _get_state_ids_after_missing_prev_event(
)

logger.debug(
"state_ids returned %i state events, %i auth events",
"_get_state_ids_after_missing_prev_event(event_id=%s): state_ids returned %i state events, %i auth events",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just giving all of these a namespaced/scoped context to easily compartmentalize them and follow down the rabbit hole.

@MadLittleMods MadLittleMods changed the title Draft: Fix event_id always being marked as failed to fetch when _get_state_ids_after_missing_prev_event Draft: Prevent Failed to fetch missing state events... warning being logged every time we tried to fetch state_ids for a missing prev_event (_get_state_ids_after_missing_prev_event(...) Jul 11, 2022
@MadLittleMods MadLittleMods changed the title Draft: Prevent Failed to fetch missing state events... warning being logged every time we tried to fetch state_ids for a missing prev_event (_get_state_ids_after_missing_prev_event(...) Draft: Prevent Failed to fetch missing state events... warning being logged every time we tried to fetch state_ids for a missing prev_event (_get_state_ids_after_missing_prev_event(...)) Jul 11, 2022
…etch

Conflicts:
	synapse/handlers/federation_event.py
@MadLittleMods
Copy link
Contributor Author

Closing as this was already fixed in #13258

The the remaining changes are just prefixing all of our log lines here. Can look into adding these when I have a need again ⏩

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant