Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix access token leak to logs from proxyagent #13855

Merged
merged 5 commits into from
Sep 23, 2022
Merged

Fix access token leak to logs from proxyagent #13855

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a5eb7f9
Fix access token leak to logs from proxyagent
MadLittleMods Sep 20, 2022
e854abb
Add changelog
MadLittleMods Sep 20, 2022
4254c20
Convert bytes to string
MadLittleMods Sep 20, 2022
0b3cda0
Decode in a way that doesn't fail
MadLittleMods Sep 20, 2022
84b4afc
Fix lints
MadLittleMods Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion synapse/http/proxyagent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
from twisted.web.http_headers import Headers
from twisted.web.iweb import IAgent, IBodyProducer, IPolicyForHTTPS

from synapse.http import redact_uri
from synapse.http.connectproxyclient import HTTPConnectProxyEndpoint, ProxyCredentials
from synapse.types import ISynapseReactor

Expand Down Expand Up @@ -220,7 +221,7 @@ def request(
self._reactor, parsed_uri.host, parsed_uri.port, **self._endpoint_kwargs
)

logger.debug("Requesting %s via %s", uri, endpoint)
logger.debug("Requesting %s via %s", redact_uri(uri), endpoint)
MadLittleMods marked this conversation as resolved.
Show resolved Hide resolved

if parsed_uri.scheme == b"https":
tls_connection_creator = self._policy_for_https.creatorForNetloc(
Expand Down