Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Revert "Avoid returning an unused column." #13935

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

clokep
Copy link
Member

@clokep clokep commented Sep 28, 2022

Reverts #13933.

Turns out this is used, but in a confusing spot further down in the code:

# If we pulled out a limited number of rows we only update the
# position to the last receipt we processed, so we continue
# processing the rest next iteration.
upper_limit = rows[-1][0]

@clokep clokep requested a review from a team as a code owner September 28, 2022 15:01
@clokep clokep merged commit 1386ce4 into develop Sep 28, 2022
@clokep clokep deleted the revert-13933-clokep/unused-stream-id branch September 28, 2022 15:01
@DMRobertson
Copy link
Contributor

Arg, sorry.

I suppose we wouldn't have been able to catch this without castint the type of rows. Frustrating.

@DMRobertson
Copy link
Contributor

(Did CI not catch this on #13933?)

@clokep
Copy link
Member Author

clokep commented Sep 28, 2022

(Did CI not catch this on #13933?)

It did not, I think none of the tests hit a 100 receipt limit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants