Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Quieter logging for stateres failure at missing prev events #14346

Merged
merged 2 commits into from
Nov 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/14346.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Concisely log a failure to resolve state due to missing `prev_events`.
5 changes: 2 additions & 3 deletions synapse/handlers/federation_event.py
Original file line number Diff line number Diff line change
Expand Up @@ -1065,10 +1065,9 @@ async def _compute_event_context_with_maybe_missing_prevs(
state_res_store=StateResolutionStore(self._store),
)

except Exception:
except Exception as e:
logger.warning(
"Error attempting to resolve state at missing prev_events",
exc_info=True,
"Error attempting to resolve state at missing prev_events: %s", e
)
raise FederationError(
"ERROR",
Expand Down