Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Actually use the picture_claim as configured in OIDC config. #14751

Merged
merged 2 commits into from
Dec 29, 2022
Merged

Actually use the picture_claim as configured in OIDC config. #14751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28e06d2
Actually use the picture_claim as configured in OIDC config.
clokep Dec 29, 2022
89b98e2
Newsfragment
clokep Dec 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/14751.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug introduced in Synapse 1.73.0 where the `picture_claim` configured under `oidc_providers` was unused (the default value of `"picture"` was used instead).
2 changes: 1 addition & 1 deletion synapse/handlers/oidc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1615,7 +1615,7 @@ def render_template_field(template: Optional[Template]) -> Optional[str]:
if email:
emails.append(email)

picture = userinfo.get("picture")
picture = userinfo.get(self._config.picture_claim)

return UserAttributeDict(
localpart=localpart,
Expand Down