Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Unix Sockets for HTTP Replication #15708

Merged

Commits on May 30, 2023

  1. Fixup how the HTTPConnectionPool key is declared and comments around/…

    …about it(including some spoilers)
    realtyem committed May 30, 2023
    Configuration menu
    Copy the full SHA
    214b7a4 View commit details
    Browse the repository at this point in the history
  2. Drive by fix: remove the disambiguity of seeing 'master' instead of '…

    …main' when referencing the instance_map.
    realtyem committed May 30, 2023
    Configuration menu
    Copy the full SHA
    b41435a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ca21dce View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Changelog

    realtyem committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    e75b177 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0aeae16 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2023

  1. Configuration menu
    Copy the full SHA
    7d03b2d View commit details
    Browse the repository at this point in the history
  2. [OPTIONAL REVERT] Change Type[Model] to TypeAlias as a Hack

    I don't know how to correctly Type this, now that there is a Union in the mix and I couldn't pin a good example to show me how it's done properly.
    
    This can be reverted to cleanly take it back to how it was before, so it can be fixed correctly.
    realtyem committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    0d79903 View commit details
    Browse the repository at this point in the history
  3. Try writing some docs

    realtyem committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    7bc139a View commit details
    Browse the repository at this point in the history
  4. Experimental testing setup for Unix sockets with Complement.

    Enable testing Unix sockets by passing UNIX_SOCKETS=1 (yes, it's plural) to the command line when running Complement, or export to the environment ahead of time.
    
    I apologize for the liberties I took with Opinions for this implementation.
    1. The main process gets two sockets, one for public(client and federation) traffic, and one for private(replication) traffic. These were placed at /run/mainpublic.sock and /run/mainprivate.sock, respectively.
    2. Additionally, for workers, the sockets were placed at /run/worker.{port_number}. I would have preferred to name them according to worker_name, but that would have taken a much deeper restructure of the configure_workers_and_start.py than I was prepared to make. This approach still allows them to be sequentially numbered just as the ports are now.
    3. Redis and Postgres also get the Unix socket treatment while here.
    realtyem committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    acd56db View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e14422f View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Revert "Drive by fix: remove the disambiguity of seeing 'master' inst…

    …ead of 'main' when referencing the instance_map."
    
    This reverts commit b41435a.
    realtyem committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    eb65470 View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: Eric Eastwood <madlittlemods@gmail.com>
    realtyem and MadLittleMods authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    e234ce9 View commit details
    Browse the repository at this point in the history
  3. Nit over formatting

    realtyem committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    6a5e705 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Add in error messages to unit test setup to discourage using Unix soc…

    …kets for *listeners or instance_map
    realtyem committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    ee55d2a View commit details
    Browse the repository at this point in the history
  2. Unify various incarnations of main_public.sock(and main_private.sock)…

    … to be all the same throughout PR
    realtyem committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    e3d4fb4 View commit details
    Browse the repository at this point in the history
  3. Add detail to docs about Synapse not creating a directory auto-magica…

    …lly for a Unix socket
    realtyem committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    fe18b66 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9394941 View commit details
    Browse the repository at this point in the history
  5. Try seeing what the doc renderer will do with 4 #'s for a subheading(…

    …for the Added in subsection)
    realtyem committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    79f63fc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c4646ee View commit details
    Browse the repository at this point in the history
  7. Apply suggestions from code review

    Co-authored-by: Eric Eastwood <madlittlemods@gmail.com>
    realtyem and MadLittleMods authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    9882e0a View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Configuration menu
    Copy the full SHA
    52f84a2 View commit details
    Browse the repository at this point in the history
  2. Fix lack of detail in contributing guide for how to use Unix socket f…

    …unctionality in Complement
    realtyem committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    86c5fd5 View commit details
    Browse the repository at this point in the history
  3. Try and fix comment in ReplicationAgent to be clearer about why not u…

    …sing _ensureValidURI() (and a further drive by fix in the docstring)
    realtyem committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    e091ea2 View commit details
    Browse the repository at this point in the history
  4. Adjust changelog.d/15708.feature

    Co-authored-by: Eric Eastwood <madlittlemods@gmail.com>
    realtyem and MadLittleMods authored Jun 16, 2023
    Configuration menu
    Copy the full SHA
    4946cb0 View commit details
    Browse the repository at this point in the history
  5. Update docs/usage/configuration/config_documentation.md

    Co-authored-by: Eric Eastwood <madlittlemods@gmail.com>
    realtyem and MadLittleMods authored Jun 16, 2023
    Configuration menu
    Copy the full SHA
    0b1a943 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Update docs a bit more

    realtyem committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    39597fc View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Apply suggestions from code review

    Co-authored-by: Eric Eastwood <madlittlemods@gmail.com>
    realtyem and MadLittleMods authored Jun 21, 2023
    Configuration menu
    Copy the full SHA
    6dbc402 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2f20dda View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5de0ef1 View commit details
    Browse the repository at this point in the history
  4. unindent entire block

    realtyem committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    85eba85 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Revert to Type[Model] to keep type variable constrained; add type i…

    …gnores to work around mypy deficiency
    reivilibre committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    4c9de6f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    67c278a View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Configuration menu
    Copy the full SHA
    a5d500f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    41d2aae View commit details
    Browse the repository at this point in the history
  3. Fixup for new proxyagent

    realtyem committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    fdb07e8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cd1579b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4f079d8 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Revert "[REVERT THIS] Hardwire testing the proxy agent into Complemen…

    …t temporarily"
    
    This reverts commit 4f079d8.
    realtyem committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    9f41f3e View commit details
    Browse the repository at this point in the history
  2. Revert "[REVERT THIS] Enable testing for the Complement CI, each test…

    … will use unix sockets"
    
    This reverts commit e14422f.
    realtyem committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    0ae6036 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    92c6c7b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cd047fe View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Configuration menu
    Copy the full SHA
    517654f View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Swap getClientAddress().host call for the UNIXAddress compatible repl…

    …acment, allowing tracing to correctly tag spans.
    realtyem committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    3789a4f View commit details
    Browse the repository at this point in the history