This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix port script for user directory tables #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/synapse_port_db
Outdated
| return | ||
|
|
||
| if table == "user_directory_stream_pos": | ||
| # We need to make sure there is a single row, `(X, null)` |
There was a problem hiding this comment.
Why do we need a single row OOI? (It might be helpful to say here in the comment)
spantaleev
added a commit
to spantaleev/matrix-docker-ansible-deploy
that referenced
this pull request
Oct 14, 2017
The non-working script is supposed to be fixed by matrix-org/synapse#2375 To have it work, we'd need an updated Docker image of `silviof/matrix-riot-docker:latest`, which is not yet available at the time of this commit. Still, the previous patched synapse_port_db didn't work well either, so it's not like we're regressing much by getting rid of it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.