Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Query missing cross-signing keys on local sig upload #7289

Merged
merged 33 commits into from
Apr 22, 2020
Merged

Query missing cross-signing keys on local sig upload #7289

merged 33 commits into from
Apr 22, 2020

Commits on Apr 20, 2020

  1. Query missing cross-signing keys on local sig upload

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    8348481 View commit details
    Browse the repository at this point in the history

  2. Add changelog

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    1063495 View commit details
    Browse the repository at this point in the history

  3. Save retrieved keys to the db

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    cc86457 View commit details
    Browse the repository at this point in the history

  4. lint

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    c265bc7 View commit details
    Browse the repository at this point in the history

  5. Fix and de-brittle remote result dict processing

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    39ed9f6 View commit details
    Browse the repository at this point in the history

  6. Use query_user_devices instead, assume only master, self_signing key … 

    …types
    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    fd8d154 View commit details
    Browse the repository at this point in the history

  7. Make changelog more useful

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    759b6b0 View commit details
    Browse the repository at this point in the history

  8. Remove very specific exception handling

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    03d2c8c View commit details
    Browse the repository at this point in the history

  9. Wrap get_verify_key_from_cross_signing_key in a try/except

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    b386658 View commit details
    Browse the repository at this point in the history

  10. Note that _get_e2e_cross_signing_verify_key can raise a SynapseError

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    bd9a671 View commit details
    Browse the repository at this point in the history

  11. lint

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    745e653 View commit details
    Browse the repository at this point in the history

  12. Add comment explaining why this is useful

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    f8b6f14 View commit details
    Browse the repository at this point in the history

  13. Only fetch master and self_signing key types

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    37ae643 View commit details
    Browse the repository at this point in the history

  14. Fix log statements, docstrings

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    83861c3 View commit details
    Browse the repository at this point in the history

  15. Remove extraneous items from remote query try/except

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    671178b View commit details
    Browse the repository at this point in the history

  16. lint

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    2d88b5d View commit details
    Browse the repository at this point in the history

  17. Factor key retrieval out into a separate function

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    f417300 View commit details
    Browse the repository at this point in the history

  18. Send device updates, modeled after SigningKeyEduUpdater._handle_signi… 

    …ng_key_updates
    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    2f87051 View commit details
    Browse the repository at this point in the history

  19. Update method docstring

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    5990d1c View commit details
    Browse the repository at this point in the history

  20. Remove extraneous key_id and verify_key

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    4f8ba5c View commit details
    Browse the repository at this point in the history

  21. Update changelog

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    9240abc View commit details
    Browse the repository at this point in the history

  22. Update changelog

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    3282423 View commit details
    Browse the repository at this point in the history

  23. Resolve review comments

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    95dd9d5 View commit details
    Browse the repository at this point in the history

  24. lint

    @anoadragon453
    anoadragon453 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    4f41f37 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2020

  1. Update changelog.d/7289.bugfix 

    Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @anoadragon453 @richvdh
    anoadragon453 and richvdh authored Apr 21, 2020
    Configuration menu
    Copy the full SHA
    6d559ba View commit details
    Browse the repository at this point in the history

  2. Refactor _get_e2e_cross_signing_verify_key

    @anoadragon453
    anoadragon453 committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    1b4dda5 View commit details
    Browse the repository at this point in the history

  3. Refactor and add validation to _retrieve_cross_signing_keys_for_remot… 

    …e_user
    @anoadragon453
    anoadragon453 committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    7cb1e48 View commit details
    Browse the repository at this point in the history

  4. Improve details of query_client_keys and query_user_devices docstrings

    @anoadragon453
    anoadragon453 committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    74eaac0 View commit details
    Browse the repository at this point in the history

  5. lint

    @anoadragon453
    anoadragon453 committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    b08b7c7 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'anoa/query_cross_signing_keys_key_upload' of github.com… 

    …:matrix-org/synapse into anoa/query_cross_signing_keys_key_upload

* 'anoa/query_cross_signing_keys_key_upload' of github.com:matrix-org/synapse:
  Update changelog.d/7289.bugfix
    @anoadragon453
    anoadragon453 committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    de29d1f View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2020

  1. Address review comments

    @anoadragon453
    anoadragon453 committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    8484a72 View commit details
    Browse the repository at this point in the history

  2. JSON brace endings on separate lines

    @anoadragon453
    anoadragon453 committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    2932b9b View commit details
    Browse the repository at this point in the history

  3. Spaces and braces

    @anoadragon453
    anoadragon453 committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    ebea2ee View commit details
    Browse the repository at this point in the history