Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Performance improvements and refactor of Ratelimiter #7595

Merged
merged 33 commits into from
Jun 5, 2020
Merged

Performance improvements and refactor of Ratelimiter #7595

merged 33 commits into from
Jun 5, 2020

Commits on May 28, 2020

  1. Refactor and comment ratelimiting. Set limits in constructor

    @anoadragon453
    anoadragon453 committed May 28, 2020
    Configuration menu
    Copy the full SHA
    4f715be View commit details
    Browse the repository at this point in the history

  2. Ratelimiters are instantiated by the HomeServer class 

    This makes it simple for tests to modify/nullify them.
    @anoadragon453
    anoadragon453 committed May 28, 2020
    Configuration menu
    Copy the full SHA
    0e6ee7c View commit details
    Browse the repository at this point in the history

  3. Modify servlets to pull Ratelimiters from HomeServer class

    @anoadragon453
    anoadragon453 committed May 28, 2020
    Configuration menu
    Copy the full SHA
    82eac22 View commit details
    Browse the repository at this point in the history

  4. Update unittests

    @anoadragon453
    anoadragon453 committed May 28, 2020
    Configuration menu
    Copy the full SHA
    a0ef594 View commit details
    Browse the repository at this point in the history

  5. lint

    @anoadragon453
    anoadragon453 committed May 28, 2020
    Configuration menu
    Copy the full SHA
    6a07c2d View commit details
    Browse the repository at this point in the history

  6. changelog

    @anoadragon453
    anoadragon453 committed May 28, 2020
    Configuration menu
    Copy the full SHA
    c322ba0 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2020

  1. Make rate_hz and burst_count overridable per-request

    @anoadragon453
    anoadragon453 committed May 29, 2020
    Configuration menu
    Copy the full SHA
    f6203a6 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2020

  1. Set clock with constructor, store rate_hz per key again

    @anoadragon453
    anoadragon453 committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    1f6156b View commit details
    Browse the repository at this point in the history

  2. Instantiate Ratelimiters in respective classes 

    Other than the registration ratelimiter, as that's used in multiple classes and
needs to keep the same state
    @anoadragon453
    anoadragon453 committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    c236806 View commit details
    Browse the repository at this point in the history

  3. Use patch for the Ratelimiter in some tests. Set using config in others

    @anoadragon453
    anoadragon453 committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    470de6e View commit details
    Browse the repository at this point in the history

  4. Update copyright header

    @anoadragon453
    anoadragon453 committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    515a186 View commit details
    Browse the repository at this point in the history

  5. Remove resolved question

    @anoadragon453
    anoadragon453 committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    87ab836 View commit details
    Browse the repository at this point in the history

  6. lint

    @anoadragon453
    anoadragon453 committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    56c52a5 View commit details
    Browse the repository at this point in the history

  7. lint, mypy

    @anoadragon453
    anoadragon453 committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    2d7e087 View commit details
    Browse the repository at this point in the history

  8. Remove unittest.DEBUG statement

    @anoadragon453
    anoadragon453 committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    a566b46 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2020

  1. Update changelog.d/7595.misc 

    Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
    @anoadragon453 @clokep
    anoadragon453 and clokep authored Jun 2, 2020
    Configuration menu
    Copy the full SHA
    41c7288 View commit details
    Browse the repository at this point in the history

  2. Remove erroneous print statement

    @anoadragon453
    anoadragon453 committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    58d4919 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'anoa/ratelimit_config_perf' of github.com:matrix-org/sy… 

    …napse into anoa/ratelimit_config_perf

* 'anoa/ratelimit_config_perf' of github.com:matrix-org/synapse:
  Update changelog.d/7595.misc
    @anoadragon453
    anoadragon453 committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    aa1f4c3 View commit details
    Browse the repository at this point in the history

  4. Move update after optional method arguments

    @anoadragon453
    anoadragon453 committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    39b484b View commit details
    Browse the repository at this point in the history

  5. Make it obvious that time_now_s is just for testing

    @anoadragon453
    anoadragon453 committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    d727bed View commit details
    Browse the repository at this point in the history

  6. Update ratelimiter calling methods and tests

    @anoadragon453
    anoadragon453 committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    9f76a8d View commit details
    Browse the repository at this point in the history

  7. No need to re-check for None in can_do_action

    @anoadragon453
    anoadragon453 committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    8867900 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2020

  1. time_now_s is used in ratelimit

    @anoadragon453
    anoadragon453 committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    ef7383f View commit details
    Browse the repository at this point in the history

  2. Comment changes revolving around time_allowed

    @anoadragon453
    anoadragon453 committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    189c01b View commit details
    Browse the repository at this point in the history

  3. Fix missed call to self.rate_hz

    @anoadragon453
    anoadragon453 committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    4a88edb View commit details
    Browse the repository at this point in the history

  4. Test Ratelimiter ratelimit method and param overrides

    @anoadragon453
    anoadragon453 committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    14a0af5 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Back out some changes.

    @clokep
    clokep committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    c145c81 View commit details
    Browse the repository at this point in the history

  2. Do not specify ratelimiters in tests when unnecessary.

    @clokep
    clokep committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    12b4d47 View commit details
    Browse the repository at this point in the history

  3. Update timestamp comment

    @anoadragon453
    anoadragon453 committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    d84d779 View commit details
    Browse the repository at this point in the history

  4. Clean up Exception raising assertion

    @anoadragon453
    anoadragon453 committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    45a7791 View commit details
    Browse the repository at this point in the history

  5. Clean up and split out tests

    @anoadragon453
    anoadragon453 committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    3899589 View commit details
    Browse the repository at this point in the history

  6. Remove _ = style

    @anoadragon453
    anoadragon453 committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    08c5114 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'anoa/ratelimit_config_perf' of github.com:matrix-org/sy… 

    …napse into anoa/ratelimit_config_perf
    @anoadragon453
    anoadragon453 committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    9beee5f View commit details
    Browse the repository at this point in the history