This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Create a ListenerConfig object #7681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ended up being a bit more invasive than I'd hoped for (not helped by generic_worker duplicating some of the code from homeserver), but hopefully it's an improvement. The idea is that, rather than storing unstructured `dict`s in the config for the listener configurations, we instead parse it into a structured `ListenerConfig` object.
richvdh
force-pushed
the
rav/listener_config_obj
branch
from
b2bf7ee
to
6c7e272
Compare
|
this is going to need matrix-org/sytest#888 before it will work correctly: |
|
I kicked off the tests again, looks like they're passing now! 👍 |
clokep
reviewed
Jun 15, 2020
| bind_addresses = listener_config["bind_addresses"] | ||
| tls = listener_config.get("tls", False) | ||
| site_tag = listener_config.get("tag", port) | ||
| def _listener_http(self, config: HomeServerConfig, listener_config: ListenerConfig): |
There was a problem hiding this comment.
I think if any of the comments for the worker version end up in changes we'll need to make them here too.
|
thanks for the review @clokep! ptal? |
richvdh
force-pushed
the
rav/listener_config_obj
branch
from
a9f332e
to
b876a82
Compare
clokep
approved these changes
Jun 16, 2020
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '03619324f': Create a ListenerConfig object (#7681) Fix changelog wording 1.15.1 Wrap register_device coroutine in an ensureDeferred (#7684) Ensure the body is a string before comparing push rules. (#7701) Ensure etag is a string for GET room_keys/version response (#7691) Update m.id.phone to use 'phone' instead of 'number' (#7687) Fix "There was no active span when trying to log." error (#7698) Enable 3PID add/bind/unbind endpoints on r0 routes Discard RDATA from already seen positions. (#7648) Replace iteritems/itervalues/iterkeys with native versions. (#7692) Fix warnings about losing log context during UI auth. (#7688) Fix a typo when comparing the URI & method during UI Auth. (#7689) Remove "user_id" from GET /presence. (#7606) Increase the default SAML session expirary time to 15 minutes. (#7664) fix typo in sample_config.yaml (#7652) Take out a lock before modifying _CACHES (#7663) Add option to enable encryption by default for new rooms (#7639) Clean-up the fallback login code. (#7657)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ended up being a bit more invasive than I'd hoped for (not helped by
generic_worker duplicating some of the code from homeserver), but hopefully
it's an improvement.
The idea is that, rather than storing unstructured
dicts in the config forthe listener configurations, we instead parse it into a structured
ListenerConfigobject.