Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Ignore the UI Auth sessions when porting from sqlite to postgresql #7711

Merged
merged 3 commits into from
Jun 17, 2020

Conversation

clokep
Copy link
Member

@clokep clokep commented Jun 16, 2020

Adds the two UI auth sessions tables to the set of tables to ignore, also pulls that list of tables out as a constant (and makes it a set).

Fixes #7654

@clokep clokep requested a review from a team June 16, 2020 17:31
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given the conversation in the issue.

@clokep clokep merged commit 6418b03 into develop Jun 17, 2020
@clokep clokep deleted the clokep/port-db-ui-auth-sessions branch June 17, 2020 14:01
@gjsmo
Copy link

gjsmo commented Jun 17, 2020

FWIW I'm pretty sure the table is not called users_in_pubic_room...

@clokep
Copy link
Member Author

clokep commented Jun 17, 2020

FWIW I'm pretty sure the table is not called users_in_pubic_room...

The two tables are ui_auth_sessions and ui_auth_sessions_credentials which got added in this PR.

@clokep
Copy link
Member Author

clokep commented Jun 17, 2020

FWIW I'm pretty sure the table is not called users_in_pubic_room...

Ah, yeah this was a typoed version from an old database schema. I guess we should update that. I'll do a separate PR!

@gjsmo
Copy link

gjsmo commented Jun 17, 2020

Yeah I saw the old code, just a very funny and rather unfortunate typo,

@clokep
Copy link
Member Author

clokep commented Jun 17, 2020

Yeah, thanks. I put up #7717.

babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit '6418b0379':
  Ignore the UI Auth sessions when porting from sqlite to postgresql (#7711)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

synapse_port_db fails when ui_auth_sessions table is non-empty
3 participants