-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add a clarification for the public_baseurl property. #7906
Conversation
@zblesk Can you make the corresponding change in |
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
Well. I tried updating until it stopped complainng about mismatches and trailing spaces; now it says |
@zblesk Please take a look at the contributing guide: https://github.com/matrix-org/synapse/blob/develop/CONTRIBUTING.md#changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for contributing!
Honestly though, I'm not sure this adds any clarity to what's there already. Doesn't it just repeat the existing description?
existing:
this should be the URL to reach synapse [via the proxy]
new:
this URL should point to Synapse itself.
... those are basically the same, no?
I realise it's confusing, but I don't think that saying the same thing over and over is going to help.
Unfortunately, I don't really have any better suggestions here :/
As mentioned above, I'm only doing this because gus in the #synapse channel asked me to, after I got stuck on this point. I do not have any improvements for this. |
Thanks for your contribution. I'm going to close this per @richvdh's comment above. |
I have been a bit confused about the correct way to set the
public_baseurl
and did it wrong. I've realized the mistake with some help from the folks in #synapse:matrix.org and they suggested I try and add a clarification to the sample file. So that's what I'm trying to do.Signed-off-by: Ladislav Benc ladislav.benc@protonmail.com