Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Revert "Add experimental support for sharding event persister. (#8170)" #8242

Merged
merged 2 commits into from
Sep 4, 2020

Conversation

babolivier
Copy link
Contributor

This reverts commit #8170 which ALTER TABLE schema update is causing performance issues.

@babolivier babolivier requested a review from a team September 3, 2020 15:14
@babolivier babolivier self-assigned this Sep 3, 2020
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turns out the ALTER TABLE probably isn't a real problem unless you happen to coincide with an uniterruptible VACUUM; nevertheless #8170 seems to have caused matrix-org/sytest#948, so 👍 from me

@babolivier babolivier merged commit 9f8abdc into develop Sep 4, 2020
@babolivier babolivier deleted the babolivier/revert_8170 branch September 4, 2020 09:19
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit '9f8abdcc3':
  Revert "Add experimental support for sharding event persister. (#8170)" (#8242)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants