Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Allow spam-checker modules to be async #8890

Merged
merged 14 commits into from
Dec 11, 2020
Merged

Allow spam-checker modules to be async #8890

merged 14 commits into from
Dec 11, 2020

Commits on Dec 8, 2020

  1. Make check_event_for_spam async 

    Method `check_event_for_spam` in both `class SpamCheck` and in plug-in spam checkers is currently
sync. This makes it impossible to write spam checkers that need to e.g. check with a database
before responding.

Signed-off-by: Your Name <davidt@element.io>
    @Yoric
    Yoric committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    2bec29c View commit details
    Browse the repository at this point in the history

  2. Use inlineCallbacks to potentially handle an async spam check method. 

    Note that this would ideally switch the entire callstack to async/await
instead, but the callstack is complicated by using many callback functions
and a DeferredList.
    @clokep
    clokep committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    25a44b6 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. Allow spam methods to be async.

    @clokep
    clokep committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    d8c5eab View commit details
    Browse the repository at this point in the history

  2. Update documentation.

    @clokep
    clokep committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    c812fa4 View commit details
    Browse the repository at this point in the history

  3. Use maybe_awaitable consistently.

    @clokep
    clokep committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    2dc2de4 View commit details
    Browse the repository at this point in the history

  4. Note that check_event_for_spam can return a string.

    @clokep
    clokep committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    4ea5973 View commit details
    Browse the repository at this point in the history

  5. Fix type hints.

    @clokep
    clokep committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    c02ebc6 View commit details
    Browse the repository at this point in the history

  6. Update changelog.

    @clokep
    clokep committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    fdd9731 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/develop' into async-spamcheck

    @clokep
    clokep committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    2cd81dc View commit details
    Browse the repository at this point in the history

  8. Fix incompatible syntax.

    @clokep
    clokep committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    0f96a96 View commit details
    Browse the repository at this point in the history

  9. Don't override variable.

    @clokep
    clokep committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    c2b54b1 View commit details
    Browse the repository at this point in the history

  10. Add a few missing calls.

    @clokep
    clokep committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    f78ba2b View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. Revert changes to maybe_awaitable.

    @clokep
    clokep committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    5e8fadc View commit details
    Browse the repository at this point in the history

  2. Revert comment.

    @clokep
    clokep committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    9a21585 View commit details
    Browse the repository at this point in the history