Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove Request return value from make_request #8946

Merged
merged 7 commits into from
Dec 16, 2020
Merged

Remove Request return value from make_request #8946

merged 7 commits into from
Dec 16, 2020

Commits on Dec 15, 2020

  1. Replace request.code with channel.code 

    The two are equivalent, but really we want to check the HTTP result that got
returned to the channel, not the code that the Request object *intended* to
return to the channel.
    @richvdh
    richvdh committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    7eebe4b View commit details
    Browse the repository at this point in the history

  2. remove 'response' result from _get_shared_rooms

    @richvdh
    richvdh committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    0378581 View commit details
    Browse the repository at this point in the history

  3. Skip redundant check on request.args

    @richvdh
    richvdh committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    5bcf6e8 View commit details
    Browse the repository at this point in the history

  4. Remove redundant reading of SynapseRequest.args 

    this didn't seem to be doing a lot, so remove it.
    @richvdh
    richvdh committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    ac2acf1 View commit details
    Browse the repository at this point in the history

  5. Remove spurious "SynapseRequest" result from `make_request" 

    This was never used, so let's get rid of it.
    @richvdh
    richvdh committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    394516a View commit details
    Browse the repository at this point in the history

  6. changelog

    @richvdh
    richvdh committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    ed61fe4 View commit details
    Browse the repository at this point in the history

  7. lint

    @richvdh
    richvdh committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    c9dd47d View commit details
    Browse the repository at this point in the history