Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove cache for get_shared_rooms_for_users #9416

Merged
merged 4 commits into from
Feb 22, 2021
Merged

Remove cache for get_shared_rooms_for_users #9416

merged 4 commits into from
Feb 22, 2021

Commits on Feb 22, 2021

  1. Drop cache for get_shared_rooms_for_users 

    It's not clear that the benefit of caching this function outweighs
the performance cost of invalidating the cache when the underlying
tables change.
    @anoadragon453
    anoadragon453 committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    46b58ac View commit details
    Browse the repository at this point in the history

  2. Fix docstring of add_users_in_public_rooms

    @anoadragon453
    anoadragon453 committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    9e3f535 View commit details
    Browse the repository at this point in the history

  3. Fix tests to check the shared_rooms endpoints multiple times 

    Beforehand, with the cache added, multiple calls would give back the same
results, even if the users started sharing a new room in-between those calls.

Removing the cache should fix the problem, but it's a good idea to add tests
to cache the mistake in the future; in case we do decide to add a cache again.
    @anoadragon453
    anoadragon453 committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    bfb7833 View commit details
    Browse the repository at this point in the history

  4. Changelog

    @anoadragon453
    anoadragon453 committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    94022c4 View commit details
    Browse the repository at this point in the history