Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more tag technologies on Android #34

Merged

Conversation

magnuswikhog
Copy link

This adds support for technologies other than NFC-A on Android, which will make the plugin work for a lot more RFID-tags.

@matteocrippa
Copy link
Owner

@magnuswikhog thanks, if this add support to any new specific technology can you check also the readme if needs any update?

@magnuswikhog
Copy link
Author

From what I understand the added technologies include all (or at least most) NFC tags. This info could be added to README, but then it would be important to find out which technologies are supported on iOS as well to avoid confusion. Perhaps a change is needed for iOS to support these technologies as well, but I don't know. So I'm thinking it's probably better to leave it out of README until someone takes the time to find out what is supported on iOS.

@matteocrippa
Copy link
Owner

@magnuswikhog CoreNFC supports from type 1 to type 5 ( https://developer.apple.com/documentation/corenfc#overview )

@magnuswikhog
Copy link
Author

Okay so for Android the README should say that it can handle

  • NFC-A
  • NFC-B
  • NFC-F
  • NFC-V
  • NFC-BARCODE (?)

and for iOS

  • TYPE 1
  • TYPE 2
  • TYPE 3
  • TYPE 4
  • TYPE 5

This table lists the correlation between these different types: https://www.dummies.com/wp-content/uploads/Tag-Types.jpg (sorry, couldn't find a higher resolution version).

This is the first time I make a PR, so not sure if/how I can include changes in the README at this stage? Or should I create a new PR for that?

@magnuswikhog
Copy link
Author

Updated the README

@matteocrippa matteocrippa merged commit 663ede0 into matteocrippa:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants