Skip to content
This repository has been archived by the owner on Oct 3, 2024. It is now read-only.

Fix: ERC20Fixed paymaster tutorial #1018

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Fix: ERC20Fixed paymaster tutorial #1018

merged 6 commits into from
Apr 10, 2024

Conversation

uF4No
Copy link
Contributor

@uF4No uF4No commented Apr 9, 2024

What 💻

  • Fix code snippet for testing
  • Reorg content to test locally before deploying to testnet
  • Some rephrases to better explain how the paymaster works

Why ✋

  • Tutorial not working and not very clear

Evidence 📷

image

Notes 📝

  • Any notes/thoughts that the reviewers should know prior to reviewing the code?

@uF4No uF4No requested review from a team as code owners April 9, 2024 14:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit ae8e9ba):

https://staging-zksync-web-era-docs--pr1018-fix-erc20-pm-tutor-u9vgswih.web.app

(expires Wed, 17 Apr 2024 11:02:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f408c7165e11221d785cc3915b60f2a4a4f277f9

MexicanAce
MexicanAce approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uF4No uF4No merged commit b7a3553 into main Apr 10, 2024
7 checks passed
@uF4No uF4No deleted the fix/erc20-pm-tutorial branch April 10, 2024 11:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MexicanAce MexicanAce MexicanAce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uF4No @MexicanAce