Focalboard Website Update V2 #4391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…update # Conflicts: # website/site/layouts/partials/head.html
|
Thanks for your patience @asaadmahmood and sorry I missed this in the holiday shuffle – I'll put this in my queue to review today/early tomorrow. |
emdecr
reviewed
Jan 4, 2023
| <img src="img/3d-icons/firstbump.svg" alt="Fistbump Icon"> | ||
| <h2>What’s next for Boards</h2> | ||
| <p> | ||
| Here are some things that we have on our <a href="https://community.mattermost.com/plugins/focalboard/team/qghzt68dq7bopgqamcnziq69ao/shared/b4ctmm917q3rzdfi451qtuxjzcw/vsyng4ghehbgsmp7gxfxk81bxxa?r=k995q65fg14cop75s8wkzxr76cc" target="_blank">roadmap</a> and plan to release soon! |
emdecr
reviewed
Jan 4, 2023
There was a problem hiding this comment.
This looks wicked! Animations are a nice touch 😎
Only things I have to mention are:
- There's a dead link under the roadmap section (made a comment)
- I think there's a preference to offload larger assets to be hosted via GitHub discussions. It's historically been a bit of a grey area, so I'll defer to @chenilim if this is necessary for merging. We had a previous conversation here. An example of a discussion I had to make to host images is here.
Otherwise, 🎉
emdecr
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Looks good to me!
Was chatting with @asaadmahmood re: off-loading images and vs being a blocker think that could be a followup PR cc: @chenilim
Approving otherwise~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Focalboard Website Update V2