Skip to content
This repository has been archived by the owner on May 20, 2022. It is now read-only.

fix typo in readme #391

Merged
merged 1 commit into from
May 15, 2019
Merged

fix typo in readme #391

merged 1 commit into from
May 15, 2019

Conversation

bepvte
Copy link
Contributor

@bepvte bepvte commented May 15, 2019

No description provided.

@mattermod
Copy link
Contributor

Thanks @redg3ar for the pull request!

Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?

This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@hanzei hanzei requested a review from pichouk May 15, 2019 04:08
@pichouk
Copy link
Contributor

pichouk commented May 15, 2019

comment out is equivalent to uncomment right ? So I guess the README is correct. Maybe I'm wrong, I'm not English native speaker.

@bepvte
Copy link
Contributor Author

bepvte commented May 15, 2019

Comment out means "remove by commenting" to me. Like, "taking the code out of the file by commenting". Since we are reintroducing code by removing the comment, I think uncomment makes sense here.

@pichouk
Copy link
Contributor

pichouk commented May 15, 2019

Then LGTM, thanks :)

@pichouk pichouk merged commit 1893b95 into mattermost:master May 15, 2019
@hanzei hanzei added the 3: Reviews Complete All reviewers have approved the pull request label May 16, 2019
nickygerritsen added a commit to Lets-Talk-NL/mattermost-docker that referenced this pull request May 28, 2019
* upstream/master: (21 commits)
  bump to 5.11.0 (mattermost#393)
  fix typo in readme (mattermost#391)
  Revert "update readme to add deprecation notice (mattermost#388)" (mattermost#389)
  include timezone for plugins that use location information. (mattermost#390)
  update readme to add deprecation notice (mattermost#388)
  update to 5.10.0
  bump to use 5.9.0
  bump to 5.8.1
  Upgrade app alpine image to 3.9
  Add Carlos Panato as maintainer
  Move Pan Luo as previous maintainer
  update MM to 5.8.0
  update MM to 5.7.2
  Enable error log to Console by default
  Upgrade to 5.7.1 (mattermost#358)
  Update docker-stack-traefik.yml
  update to 5.7.0
  bump to 5.6.3
  Add client plugins as bind mount
  add config
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants