This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
update eslint's comma-dangle
rule to always-multiline
.
#830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lieut-data
commented
Feb 16, 2018
@@ -45,7 +45,7 @@ | |||
"camelcase": [2, {"properties": "never"}], | |||
"capitalized-comments": 0, | |||
"class-methods-use-this": 0, | |||
"comma-dangle": [2, "never"], | |||
"comma-dangle": [2, "always-multiline"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only change of significance.
lieut-data
added
the
Do Not Merge
Should not be merged until this label is removed
label
Feb 16, 2018
As part of this, I'm investigating the best way to streamline rebases for feature branches. Once I have a plan for that, I'll post here and unblock the review/merge. |
To avoid merge conflicts, and assuming this commit goes in as
|
lieut-data
added
2: Dev Review
Requires review by a core commiter
and removed
Do Not Merge
Should not be merged until this label is removed
labels
Feb 16, 2018
crspeller
approved these changes
Feb 20, 2018
enahum
approved these changes
Feb 20, 2018
jasonblais
added
4: Reviews Complete
All reviewers have approved the pull request
and removed
2: Dev Review
Requires review by a core commiter
labels
Feb 21, 2018
lieut-data
force-pushed
the
comma-dangle-always-multiline
branch
from
February 21, 2018 16:21
d9ebc8f
to
4b64a85
Compare
amyblais
added
Changelog/Not Needed
Does not require a changelog entry
Docs/Not Needed
Does not require documentation
labels
Feb 21, 2018
This was referenced Feb 21, 2018
hmhealey
pushed a commit
that referenced
this pull request
Aug 28, 2020
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
4: Reviews Complete
All reviewers have approved the pull request
Changelog/Not Needed
Does not require a changelog entry
Docs/Not Needed
Does not require documentation
Tests/Not Needed
Does not require new release tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
update eslint's
comma-dangle
rule toalways-multiline
.This includes the output of invoking
yarn fix
to fix everything. Noother changes are included.
Checklist
make check-style
to check for style errors (required for all pull requests)make test
to ensure unit and component tests passed