Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for PHPUnit v9.0 #13

Merged
merged 2 commits into from
Mar 27, 2020

Conversation

ktamas77
Copy link
Contributor

@ktamas77 ktamas77 commented Mar 26, 2020

(Requires more refactoring - closed. See #14)

@matthiasnoback matthiasnoback merged commit 925ae86 into matthiasnoback:master Mar 27, 2020
@matthiasnoback
Copy link
Owner

Thanks!

@matthiasnoback
Copy link
Owner

Somehow the Travis build didn't run for this PR. Once merged and released the build was broken. This library simply doesn't work yet with PHPUnit 9. If you have time to look into it, please do so. For me it would not be a problem if the PHPUnit 9 support would mean we release a new major version. So if you'd like to drop support for older PHPUnit versions, that's fine by me.

@ktamas77
Copy link
Contributor Author

@matthiasnoback you right - PHPUnit 9's interface is fundamentally different, I had to refactor the code to match it properly. In order to do so, I also had to increase the minimum PHP requirement to PHP 7.3 as it's the minimum requirement for PHPUnit 9. And since it requires PHP 7.3, i dropped support for older PHP Versions. #14

@matthiasnoback
Copy link
Owner

matthiasnoback commented Mar 27, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants