Lint as a separate job

mattiasj-axis · Mar 11, 2022 · 3a67d07 · 3a67d07
1 parent 8f1d058
commit 3a67d07
Showing 1 changed file with 35 additions and 23 deletions.
diff --git a/.github/workflows/python-app.yml b/.github/workflows/python-app.yml
@@ -10,7 +10,25 @@ on:
     branches: [master]
 
 jobs:
+  lint:
+    - uses: actions/checkout@v2
+    - name: Set up Python
+      uses: actions/setup-python@v3
+      with:
+        python-version: "3.10"
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        python -m pip install flake8
+    - name: Lint with flake8
+      run: |
+        # stop the build if there are Python syntax errors or undefined names
+        flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
+        # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
+        flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+
   tests:
+    needs: lint
     runs-on: ubuntu-latest
     strategy:
       matrix:
@@ -25,13 +43,7 @@ jobs:
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
-          python -m pip install flake8 tox tox-gh-actions
-      - name: Lint with flake8
-        run: |
-          # stop the build if there are Python syntax errors or undefined names
-          flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
-          # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
-          flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+          python -m pip install tox tox-gh-actions
       - name: Test with tox
         run: tox
         env:
@@ -45,19 +57,19 @@ jobs:
     needs: tests
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-    - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v3
-      with:
-        python-version: 3.9
-    - name: Install dependencies
-      run: |
-        python -m pip install coverage
-    - uses: actions/download-artifact@v2
-      with:
-        name: coverage-results        
-    - name: Coverage check
-      run: |
-        coverage combine
-        coverage report --omit="qrcode/tests/*" --fail-under=98 -m
-        coverage report --include="qrcode/tests/*" --fail-under=100 -m
+      - uses: actions/checkout@v2
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v3
+        with:
+          python-version: 3.9
+      - name: Install dependencies
+        run: |
+          python -m pip install coverage
+      - uses: actions/download-artifact@v2
+        with:
+          name: coverage-results
+      - name: Coverage check
+        run: |
+          coverage combine
+          coverage report --omit="qrcode/tests/*" --fail-under=98 -m
+          coverage report --include="qrcode/tests/*" --fail-under=100 -m