use existing app.server #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, looks good to me. Can you fix up the test or remove it and I'll merge it in! Thanks |
|
Updated. It also checks now whether Updated tests. |
Checks to see if `app.server` exists, if so, uses that, if not, creates one. Wraps `app.listen` with warning *only* if `app.server` was created here. If `app.server` exists but it's not an http server, throws an error.
|
Thats awesome! Thanks! |
|
publish to npm please |
|
Yep, all in 4.1.0. I was going to add some other stuff but that'll take longer so it's up now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks to see if
app.serverexists, if so, uses that, if not, creates one.Wraps
app.listenwith warning only ifapp.serverwas created here.Doesn't throw error if
app.serverexists (this is causing to fail 1 test inattach.test.js'should not alter a koa app that already has .server')