Add CLI mode and log file #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
matuzalemmuller
commented
Jun 30, 2022
matuzalemmuller
commented
- Add CLI mode
- Add log file support
- Add module support & PyPi release
- Improve code quality
- Use QtDesigner to maintain PyQt5 UI
* Add some methods to enable/disable fields in DFC app
* Add progress bar update function * Start implementing signals for app functionality
* Make FilesCreator be a Child class of Thread * Move pyqtSignals from files_creator to ui * Add completion message to ui
* Add error messages for failures * Refactor method names
* Add option to include md5 hash in log entry * Add return values to some functions * Add exception handling in logging methods
* Use pyuic5 to generate python classes from ui files * Refactor code using black * Refactor folder structure to use design folder
* Add DFC icon to QMessage and QDialog windows * Add requirements files * Remove context menu from About window
- Add package.config file to parametrize package information - Add handling for absolute path in setup.py - Add some files with links and TODO for next steps
* Parse cli arguments using argparser * Small fixes in files_creator * Use tdqm for progress bar
* Add tqdm as requirement * Add tootip to UI in options that affect performance * Fix progress bar flush in success and error messages
- Make progress bar optional in CLI mode - Optimize progress bar value calculation in both CLI and UI modes - Replace string concatenation by f-strings
- Add methods to reduce "if" checks during run, improving performance - Methods sacrifice code complexity and maintenance for performance
* Fix paths included in .desktop file * Add __slots__ to all classes * Replace "debug" terminology by "verbose"
- onefile outputs one executable, slower to load due to lib compression - dir results in a folder with multiple files, faster to open - Use f-strings in linux package script
- Change import order to reflect when modules are used in __main__.py - Remove unnecessary files_creator import from some unit tests
- Fix bug that where hash was always included in log
- Merge create methods as it doesn't impact performance a lot; - Removed multiple unnecessary else and elif statements; - Remote some parameters in update functions from CLI and UI modes; - Add correct link to gif in README.md - Improve code quality as per pylint
- Format code using black - Fix path for package description in setup.py
- Add double underscore to private atributes - Use files_creator atributes instead of re-calculating file/chunk sizes - Update progress bars in async manner via separate thread
- Fix build_package script to alert that program is not installed
- Fix python shebang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.