Swapped out aiogrpc + updated MAVSDK dependencies
#712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your work @ShafSpecs. I'm currently (mostly) offline. I'll review it all when back. |
|
@ShafSpecs sorry lots going on. How is this going? Are you blocked by my review? Anything I need to be aware of? |
Yep, this PR is blocked by this one from mavsdk proto 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to update MAVSDK-Python, including dependencies, gRPC files and fix outdated dependencies.
mavsdk/async_plugin_manager.py, whereaiogrpcwas removed entirely and replaced withgrpc.aiogrpcio-tools), I executed theother/tools/run_protoc.shscript which made a lot of changes to themavsdkfolder itself.run_protoc.shscript itself. Including the utilisation of a temp file when renaming.rstfiles and adding a few new logsCaution
This PR still require edits due to utilizing un-merged changes from this PR
Closes #698