telemetry: sys_status for position health flags #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
previously approved these changes
May 29, 2022
| @@ -416,5 +419,12 @@ class TelemetryImpl : public PluginImplBase { | |||
| OffsetStatus gyro_offset; | |||
|
|
|||
| } _ap_calibration{}; | |||
|
|
|||
| enum class SysStatusUsed { | |||
There was a problem hiding this comment.
Nitpick: this could be a SysStatus { Unknown, Used, Unused } instead of something that sounds like an augmented boolean 😁
There was a problem hiding this comment.
Oh yes, good point.
julianoes
force-pushed
the
pr-health-fixes
branch
from
b6370d8
to
caef8f0
Compare
With this commit we start to use the sys_status flags to determine whether local and global position are ok. If the flags don't appear to be set, we fall back to counting GPS satellites like before.
For some reason PX4 doesn't set enabled for GPS, sadly.
julianoes
force-pushed
the
pr-health-fixes
branch
from
caef8f0
to
7cb968b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we start to use the sys_status flags to determine whether local and global position are ok. If the flags don't appear to be set, we fall back to counting GPS satellites like before.