-
-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update openssl to 3.0.5 #1811
Update openssl to 3.0.5 #1811
Conversation
ff2702b
to
4d490ff
Compare
Out of curiosity. Why? Or what's the difference from version 1.1 to 3? |
I figured it may be worth trying, to get an idea. I can see potential issues that we may encounter:
An open question is therefore whether we should support both OpenSSL 1 and OpenSSL 3, or if we could just move to OpenSSL 3, I guess? 🤔 |
Do we have openssl 3 on Ubuntu 20.04? |
No it's libssl1.1. But it seems like MAVSDK builds with both in many cases, so maybe we're lucky and it's fine to just update to 3 in our third parties and let the system take 1 when packaging? |
8684e44
to
a5e276b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having fun? 😂
e06e25a
to
8385b7d
Compare
Curl shouldn't require openssl at all.
That's an attempt to prevent the error on iOS: ld: -bundle and -bitcode_bundle (Xcode setting ENABLE_BITCODE=YES) cannot be used together
@JonasVautherin can we somehow go to XCode 14 where bitcode is apparently no longer a thing? |
Let me have a look 👍 |
This prevents me from searching through stuff in a confusing way.
255c348
to
2179b66
Compare
Merging with openssl for iOS still at 1.1.1. |
undefined reference to std::__throw_bad_array_new_length()
(edit: that was due to the dependencies cache being shared with Ubuntu 22.04)Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.so