Detect external storage format #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
force-pushed
the
handle-implicit-storage-format
branch
from
298ebf7
to
2fe04d9
Compare
julianoes
previously approved these changes
Jul 15, 2022
JonasVautherin
force-pushed
the
handle-implicit-storage-format
branch
from
2fe04d9
to
935961b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could be that some other component (or the user, manually) formats the storage. MAVSDK can detect that by observing that the
image_countbecame smaller than it was before (e.g.image_count = 30followed byimage_count = 0means that the storage was formatted). Because we can lose messages, I don't checkimage_count == 0, butlast_image_count > new_image_count. The only reason why the image count would get lower is because the storage was formatted.Also, it should work if just a few pictures are removed from the storage: here it just invalidates the whole photo list and MAVSDK has to start all over again, so that should be fine. Still, that's not a supported use case in the MAVLink specs.