Add software version type to system info #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
reviewed
Oct 24, 2022
| @@ -0,0 +1,114 @@ | |||
| // | |||
| // Simple example to demonstrate how to query system info using MAVSDK. | |||
There was a problem hiding this comment.
Awesome, thanks for adding this.
examples/system_info/system_info.cpp
Outdated
| } | ||
|
|
||
| // Get the system Version struct | ||
| const Info::Version& systemVersion = info.get_version().second; |
There was a problem hiding this comment.
Suggested change
| const Info::Version& systemVersion = info.get_version().second; | |
| const Info::Version& system_version = info.get_version().second; |
And the rest below, for consistency.
examples/system_info/system_info.cpp
Outdated
Comment on lines
91
to
102
| std::cout << " flight_sw_major: " << systemVersion.flight_sw_major << '\n' | ||
| << " flight_sw_minor: " << systemVersion.flight_sw_minor << '\n' | ||
| << " flight_sw_patch: " << systemVersion.flight_sw_patch << '\n' | ||
| << " flight_sw_version_type: " << systemVersion.flight_sw_version_type << '\n' | ||
| << " flight_sw_vendor_major: " << systemVersion.flight_sw_vendor_major << '\n' | ||
| << " flight_sw_vendor_minor: " << systemVersion.flight_sw_vendor_minor << '\n' | ||
| << " flight_sw_vendor_patch: " << systemVersion.flight_sw_vendor_patch << '\n' | ||
| << " flight_sw_git_hash: " << systemVersion.flight_sw_git_hash << '\n' | ||
| << " os_sw_major: " << systemVersion.os_sw_major << '\n' | ||
| << " os_sw_minor: " << systemVersion.os_sw_minor << '\n' | ||
| << " os_sw_patch: " << systemVersion.os_sw_patch << '\n' | ||
| << " os_sw_git_hash: " << systemVersion.os_sw_git_hash << '\n'; |
There was a problem hiding this comment.
Btw. you can also just do std::cout << systemVersion << '\n' if that's what you want.
… directory to Cmake
|
@julianoes Fixed consistency issues in the example. |
|
Thanks @CY-1992. Now only the submodule update is missing. Let me try to do that real quick. |
|
@julianoes I thought I updated the sub module with the latest commit. May I know exactly how you have updated the submodule in MAVSDK? |
|
After it has been merged in proto, I did the following steps: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not have complete understanding of MAVSDK package. I tried to implement version type in system info. I hope this pull request would close #1910 . Also created a pull request #298 in MAVSDK-Proto