Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Refactor changelog generation #1923

Merged

Conversation

Andreea-L
Copy link
Contributor

This PR reworks the generate_debian_changelog.sh. Namely it:

  • Adds args for author and email, so we stop tagging every mavsdk dev with Helge's name; when not provided, by default the author is "MAVSDK Team"
  • Replaces the previous git describe used for the default tag version with either the current commit hash (+ "0v" prepended) or the tag which points to the commit hash. This is to prevent dpkg-buildpackage errors, since in the cases where a commit is not tagged and its hash does not start with a digit, the deb build fails:
dpkg-buildpackage: error: version number does not start with digit

This meant you basically couldn't reliably issue a build on a non-tagged mavsdk commit.

Co-authored-by: Jonas Vautherin <jonas.vautherin@protonmail.ch>
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for the PR!

@julianoes julianoes merged commit 9700463 into mavlink:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants