Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Select the data inserted by ! and <a-!> #2174

Closed
wants to merge 1 commit into from

Conversation

lenormf
Copy link
Contributor

@lenormf lenormf commented Jun 30, 2018

Closes #1468

@aver-d
Copy link
Contributor

aver-d commented Nov 2, 2018

I've tested this patch for a few months. It works nicely, thanks.

The main advantage is being able to immediately press s to select inside the newly inserted text, and it's also useful for moving the entire text for alignment or indentation.

@aver-d
Copy link
Contributor

aver-d commented Nov 3, 2018

I forgot to mention that I've noticed that when the command returns no output or has an error (eg. ! printf <ret> or !unknown-cmd <ret> ), then the selection extends upwards towards the first character in the buffer.

I typically use ! programmatically inside scripts, so this has not come up much for me, but I suppose in the case of an error I'd expect no change in the current selection. Maybe an error message would be useful too.

@lenormf
Copy link
Contributor Author

lenormf commented Nov 6, 2018

I think I see where the problem is, I'll look into it.

@lenormf lenormf force-pushed the select-inserted-shell-command branch from b14c64c to 09d3404 Compare November 17, 2018 10:24
@lenormf
Copy link
Contributor Author

lenormf commented Nov 17, 2018

I fixed the issue and rebased on master.

@lenormf lenormf force-pushed the select-inserted-shell-command branch 2 times, most recently from aa10f27 to 712d847 Compare November 17, 2018 10:34
@lenormf
Copy link
Contributor Author

lenormf commented Nov 17, 2018

Updated the documentation.

@lenormf lenormf force-pushed the select-inserted-shell-command branch from 712d847 to cb8502a Compare July 22, 2021 13:13
@lenormf
Copy link
Contributor Author

lenormf commented Jul 22, 2021

Rebased on master.

@lenormf lenormf closed this Sep 8, 2021
@lenormf lenormf deleted the select-inserted-shell-command branch September 8, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select the data inserted by the ! and <a-!> primitives
2 participants