Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: Select the data inserted by ! and <a-!> #4335

Closed
wants to merge 1 commit into from
Closed

src: Select the data inserted by ! and <a-!> #4335

wants to merge 1 commit into from

Conversation

lenormf
Copy link
Contributor

@lenormf lenormf commented Sep 8, 2021

Closes #1468

@krobelus
Copy link
Contributor

I've been using this for a bit, it feels nice.
It's a minor breaking change, maybe we should do the same for p and P right away. Does anyone have an implementation of #4277 so we can try both for a while?

@mawww
Copy link
Owner

mawww commented Sep 29, 2021

I am working on a refactoring of selections insert/replace that should make implementing this much cleaner, I do agree with this change (and the p/P one) but want to finish my refactoring first.

@lenormf lenormf force-pushed the select-inserted-shell-command branch from 07bc206 to 9342991 Compare October 3, 2021 13:51
@lenormf
Copy link
Contributor Author

lenormf commented Oct 3, 2021

Rebased on master.

@lenormf lenormf force-pushed the select-inserted-shell-command branch from 9342991 to a4a0336 Compare October 20, 2021 15:46
@lenormf
Copy link
Contributor Author

lenormf commented Oct 20, 2021

Rebased on master.

@lenormf lenormf force-pushed the select-inserted-shell-command branch from a4a0336 to a26b473 Compare October 20, 2021 15:50
@mawww
Copy link
Owner

mawww commented Oct 21, 2021

I intend to merge this, I just want to make a release before going into various breaking changes

@alexherbo2 alexherbo2 mentioned this pull request Oct 27, 2021
Open
@Delapouite
Copy link
Contributor 

I intend to merge this, I just want to make a release before going into various breaking changes

As a release has been done a couple of weeks after the last message (https://github.com/mawww/kakoune/releases/tag/v2021.11.08), should this PR be merged now?

@krobelus krobelus mentioned this pull request Apr 28, 2022
Merged
@mawww mawww closed this in 52a7c58 May 1, 2022
TeddyDD pushed a commit to TeddyDD/kakoune that referenced this pull request Aug 19, 2022
@krobelus @TeddyDD
rc autorestore: fix regression due to ! breaking change
314b4c1 
Commit 85b78dd (src: Select the data inserted by `!` and `<a-!>`,
merged on 2021-03-06) broke autorestore by making it delete the
restored content.  I've been using it for 6 months but never noticed
since I didn't use autorestore

Reproducer:

	HOME=$PWD kak -s foo README.asciidoc -e 'exec iUNSAVED-CONTENT'
	# In another terminal:
	ps aux | awk '/kak -s foo/ {print $2; exit}' | xargs kill -HUP
	HOME=$PWD kak -s foo README.asciidoc

Delete the trailing newline instead of the restored content.

While at it, remove some <space> commands from execute-keys, to make
it work on the breaking-cleanups branch which swaps <space> and ",".

Closes mawww#4335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select the data inserted by the ! and <a-!> primitives
4 participants
@lenormf @krobelus @mawww @Delapouite