Fix importing of vendored packages #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x/tools/go/packages does not search inside vendor. Work around by using build.Import first to find the package in vendor. See golang/go#30289
|
Note that build.Import has a bug in go 1.13beta1 and does not work properly when GO111MODULE=auto and the directory is in GOPATH and has go.mod (or a parent directory does). This doesn't affect the tests, because they explicitly set GO111MODULE to "on" or "off", and it doesn't affect 1.12, because "auto" does not activate module mode in GOPATH under 1.12 (forcing you to use GO111MODULE=on anyway). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x/tools/go/packages does not search inside vendor.
Work around by using build.Import first to find the package in vendor.
See golang/go#30289
There aren't any tests with a vendor directory, so I only tested this manually on a project that uses it and wants to generate a fake for a vendored package. I can try to write some test fixtures if you'd like.
Fixes #75