Add compatibility with 10.11 #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxence-charriere
requested changes
Jul 7, 2018
There was a problem hiding this comment.
That is super cool.
Thank you so much for this!
Since retro compatibility can affect couple of different things, I would be more comfortable to have it all in one file retro.h that we would include wherever it is required.
That way we don't pollute the other files and where we detect new stuff we just append it in one dedicated place.
cmd/goapp/mac.go
Outdated
| @@ -213,7 +213,7 @@ func fillBundle(b driver.Bundle, root string) driver.Bundle { | |||
| } | |||
|
|
|||
| if len(b.DeploymentTarget) == 0 { | |||
| b.DeploymentTarget = "10.13" | |||
| b.DeploymentTarget = "10.11" | |||
There was a problem hiding this comment.
I would like to keep the latest version as a default value.
|
Something like this? |
maxence-charriere
requested changes
Jul 8, 2018
drivers/mac/image.h
Outdated
| @@ -3,6 +3,10 @@ | |||
|
|
|||
| #import <Cocoa/Cocoa.h> | |||
|
|
|||
| #if MAC_OS_X_VERSION_MAX_ALLOWED < 101200 | |||
There was a problem hiding this comment.
Get rid of these #if and put it just once in retro.h
|
done :) |
maxence-charriere
approved these changes
Jul 8, 2018
|
Thank you for this :)
…Sent from my iPhone
On Jul 8, 2018, at 2:02 AM, tectiv3 <notifications@github.com<mailto:notifications@github.com>> wrote:
done :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#144 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACkWe6qmtQqz-qwy9ZEOGht_JRodanC9ks5uEcqtgaJpZM4VGSlN>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does ?
goapp now can build and bundle apps for macOS 10.11
Fixes
10.11 compatibility