Uploader context #23
Merged
Uploader context #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allows for not polluting the session object, or when the session object isn't suitable for passing additional context information
|
Thank you. I'm glad that people are finding this gem useful. I just realized that Artem's changes in PR #16 were made exclusively in lib.js. When you made the changes to s3mp.js and recompiled the javascript files his changes were reverted. Would you mind patching up the individual js files with his changes and then recompiling again? I'll merge the request after that and push out a new version of the gem. Great work otherwise. |
|
Will do. Thanks. |
|
Should be ready to go Max. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Max,
Thanks for the great gem. I found it impractical to use the session object to pass the additional context information I needed for an uploaded object, so I added a context (text) attribute to the S3Multipart::Upload model itself. This can be set via a data-context attribute on the file input. The attribute can be populated with a Javascript object and parsed as JSON on the server.
I also merged in my other PRs and fixed the package.json to fix grunt at 0.3.17 otherwise npm will install grunt 0.4.x and grunt commands will fail due to your dependency on underscore (I think). I tried to resolve that dependency to move up to lodash, but wasn't able to get that working.
HTH,
-Michael